Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some docs issues #55139

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Clean up some docs issues #55139

merged 2 commits into from
Jul 18, 2024

Conversation

Octogonapus
Copy link
Sponsor Contributor

@Octogonapus Octogonapus commented Jul 15, 2024 •
edited
Loading

Closes #55055.
Closes #54686.

@Octogonapus
JuliaLang#55055: Remove incorrect BoundsError mention from iterate(st…
2bbb916 
…ring) docs.

Since at least v1.6 a bounds error has not been thrown if you iterate
outside the bounds of the string.
@nsajko nsajko added domain:docs This change adds or pertains to documentation docsystem The documentation building system labels Jul 16, 2024
@nsajko
Copy link
Contributor

nsajko commented Jul 17, 2024

This always breaks the build at an early stage.

@nsajko
Copy link
Contributor

nsajko commented Jul 17, 2024 •
edited
Loading

Also, perhaps split the PR into several smaller changes. (Maybe that's just my preferred style?)

@Octogonapus
Copy link
Sponsor Contributor Author

Octogonapus commented Jul 17, 2024 •
edited
Loading

I will split off the JuliaSyntax changes to another PR because I have done that wrong.

@nsajko nsajko removed the docsystem The documentation building system label Jul 18, 2024
@Octogonapus
Copy link
Sponsor Contributor Author

I'm not sure why the else crossref did not work. I've removed it.

@fatteneder fatteneder added the status:merge me PR is reviewed. Merge when all tests are passing label Jul 18, 2024
@IanButterworth IanButterworth merged commit 0e6d797 into JuliaLang:master Jul 18, 2024
8 checks passed
@Octogonapus Octogonapus deleted the rgb/cleanup_docs branch July 18, 2024 23:49
@oscardssmith oscardssmith removed the status:merge me PR is reviewed. Merge when all tests are passing label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iterate docs typo else isn't documented in try block docstring
6 participants
@Octogonapus @nsajko @JeffBezanson @IanButterworth @oscardssmith @fatteneder