drop jl_gc_pool_alloc in favor of instrumented version #55085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
dcn-no-pool-alloc-instrumented
branch
from
0804a45
to
99c77e3
Compare
d-netto
force-pushed
the
dcn-no-pool-alloc-instrumented
branch
from
99c77e3
to
bc42429
Compare
|
CC: @fingolfin, since you folks at Oscar et al. are probably the main users of Julia's embedding functionality. I suspect this is not breaking for you folks, but please let me know if that's not the case. Motivation of this PR is to trim the GC interface of DLLExported functions that must be implemented by a third-party GC (e.g. MMTk). |
|
Thank you for the notification! I think this is indeed fine for us. |
fingolfin
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do some re-naming.