Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark a flaky Sockets test as broken #55030

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jul 4, 2024

As suggested in #55008 (comment).

Closes #55008.

@d-netto d-netto requested a review from Keno July 4, 2024 19:28
@Keno
Copy link
Member

Keno commented Jul 4, 2024

Actually, no, broken is wrong, because it asserts the opposite. This should be test_skip.

@d-netto
Copy link
Member Author

d-netto commented Jul 4, 2024

Sounds good. Will change it.

@d-netto d-netto added the status:merge me PR is reviewed. Merge when all tests are passing label Jul 4, 2024
@d-netto d-netto force-pushed the dcn-mark-a-flaky-sockets-test-as-broken branch from 20260c4 to 03b2be8 Compare July 4, 2024 19:48
@topolarity topolarity merged commit 8f1f223 into master Jul 4, 2024
3 of 7 checks passed
@topolarity topolarity deleted the dcn-mark-a-flaky-sockets-test-as-broken branch July 4, 2024 20:42
@d-netto d-netto removed the status:merge me PR is reviewed. Merge when all tests are passing label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in comparing getnameinfo result in Sockets CI test
3 participants