cleanup remset logic a bit #55021
Merged
cleanup remset logic a bit #55021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
dcn-cleanup-remset-logic
branch
7 times, most recently
from
6d48ad2
to
216fa17
Compare
d-netto
force-pushed
the
dcn-cleanup-remset-logic
branch
from
216fa17
to
e5c6495
Compare
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jul 8, 2024
I think that keeping a single `remset` (instead of two and keep alternating between them) should be a bit easier to understand and possibly even a bit faster (since we will be accessing the `remset` only once), though that should be a very small difference.
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jul 11, 2024
I think that keeping a single `remset` (instead of two and keep alternating between them) should be a bit easier to understand and possibly even a bit faster (since we will be accessing the `remset` only once), though that should be a very small difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that keeping a single
remset(instead of two and keep alternating between them) should be a bit easier to understand and possibly even a bit faster (since we will be accessing theremsetonly once), though that should be a very small difference.