Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW: Use correct format specifier #54804

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

topolarity
Copy link
Member

On my system, this cleans up all warnings when building Julia on Windows.

@giordano
Copy link
Contributor

giordano commented Jun 14, 2024

Does this mean we can use -Werror when compiling for windows on CI? 😈

Edit: no

In function '__readgsqword',
    inlined from 'jl_init_stack_limits' at C:/workdir/src/init.c:56:25:
C:/msys64/mingw64/include/psdk_inc/intrin-impl.h:838:1: warning: array subscript 0 is outside array bounds of 'long long unsigned int[0]' [-Warray-bounds]
  838 | __buildreadseg(__readgsqword, unsigned __int64, "gs", "q")
      | ^~~~~~~~~~~~~~

😢

Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, related PR: #53764

src/julia.h Show resolved Hide resolved
@giordano giordano added domain:building Build system, or building Julia or its dependencies system:windows Affects only Windows labels Jun 14, 2024
@topolarity
Copy link
Member Author

topolarity commented Jun 14, 2024

__readgsqword

That looks like https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/[email protected]/

Presumably a GCC bug that has since been fixed? I'm using 11.4.0 locally

On my system, this cleans up all warnings when building Julia.
@gitboy16
Copy link
Contributor

gitboy16 commented Jun 15, 2024

I made a PR to fix a windows warning in utf8.c as well #54268
Please close all my PRs if this one fixes all windows warnings.

@topolarity topolarity merged commit b0b7a85 into JuliaLang:master Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants