Handle generic numbers in generic pivoted cholesky correctly #54735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working correctly now also in the generic complex case, which was not handled correctly before. Local tests indicate that the unpivoted algorithm and the pivoted algorithm (but only in the lowertriangular version) also work for Quaternions. It remains to fix the uppertriangular version of the pivoted algorithm in view of order of multiplication. |
dkarrasch
changed the title
This reverts commit 779228d.
|
Do the |
|
I hadn't removed any such annotations, but now I have added them in the new code. Now, both Cholesky decompositions will work for any |
dkarrasch
added
the
status:merge me
|
you seem to have messed up your merge. |
|
Yes, something went horribly wrong. Now it should be fixed. |
|
@dkarrasch CI is all green now. |
DilumAluthge
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.