Move GC to its own directory and library #54238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a67941
to
7166bb8
Compare
kpamnany
reviewed
Apr 25, 2024
5638bc8
to
79fdf4d
Compare
|
Bump. |
|
Shouldn't |
79fdf4d
to
bd72373
Compare
Possibly. |
b2e173f
to
3fbfd35
Compare
3fbfd35
to
12ae1bc
Compare
|
Final bump. Will merge on Thursday if no objections. |
gbaraldi
reviewed
Jun 19, 2024
gbaraldi
reviewed
Jun 19, 2024
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
IanButterworth
pushed a commit
that referenced
this pull request
Jun 21, 2024
Reverts #54238 because it fails CI (broke the gcext test) as well as deleted a large number of other test configurations (all of the static analyzer checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ongoing MMTk effort, we are aiming to make the GC more modular and allow users to specify at build time different GC implementations they want for Julia.
This is the first step in this multi-PR effort.
For now, makes the GC as a static library to keep things as simple as possible.