Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearAlgebra: fix copyto! with aliased arrays #54044

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Apr 11, 2024

Fixes #39460 by ensuring that the matrices are unaliased before copying. Also added dataids and unaliascopy for some of the wrapper types, which makes more such copyto! operations with aliased matrices return correct results.

@jishnub jishnub added linear algebra Linear algebra arrays [a, r, r, a, y, s] labels Apr 11, 2024
@N5N3 N5N3 merged commit 7ee15d1 into master Apr 16, 2024
9 checks passed
@N5N3 N5N3 deleted the jishnub/copytoalias branch April 16, 2024 12:57
@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some copyto! methods don’t check for aliasing
3 participants