update --strip-metadata for new debug format #53969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 5, 2024
|
Good point. I think it would be ok to just make them mutable then? |
|
Not ideal to mutate them ever though, since we reference them from many places |
|
And we rely on them not changing for efficient ji files |
|
How do we rely on that? But anyway, are you saying you'd prefer to make the debuginfo fields |
|
We can avoid copying them into the caller, since we know they cannot change. You could grab something like |
b1ae09c
to
8c5be43
Compare
topolarity
reviewed
Apr 16, 2024
8c5be43
to
fbbd37e
Compare
fbbd37e
to
881ac10
Compare
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to remove the DebugInfo objects themselves, but this gets the vast majority of the bytes, and removing those objects I think would require adding lots of checks in various places so this is good for now.