reland "small changes to make Base more statically compileable (#53778)" #53820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to fully-statically-type Base and init methods. The changes are from gb/small-image2.
KristofferC
reviewed
Mar 22, 2024
| global mkpidlock_hook | ||
| global trymkpidlock_hook | ||
| global parse_pidfile_hook | ||
| global mkpidlock_hook::Any |
There was a problem hiding this comment.
Out of curiosity, what effect does this have?
There was a problem hiding this comment.
A global can be given a type later, so if it doesn't have a type yet when the code is compiled we emit a convert call to an unknown type.
There was a problem hiding this comment.
Ideally global x would be identical to global x::Any (like function arguments) but that might break some use cases, not sure.
giordano
added
the
kind:re-land
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to fully-statically-type Base and init methods. The changes are from gb/small-image2.