Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Memory{T} respect the max alignment of the heap #53748

Merged
merged 3 commits into from
May 10, 2024
Merged

Make Memory{T} respect the max alignment of the heap #53748

merged 3 commits into from
May 10, 2024

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Mar 15, 2024 •
edited
Loading

Fixes #53683

vtjnash
vtjnash reviewed Mar 15, 2024
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for code_llvm(optimize=false) to check for the string align 16 and not align 64?

vchuravy
vchuravy reviewed Mar 17, 2024
View reviewed changes
test/vecelement.jl
@@ -120,3 +120,9 @@ for T in (Float64, Float32, Int64, Int32)
@test b == result
end
end
@testset "vecelement overalignment" begin
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think those kinds of test are better for llvmpasses,
since it is easy to match the wrong align here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

@KristofferC
Copy link
Sponsor Member

I'll merge this if CI is green and a better test as suggested can be added later if someone feels so inclined.

@KristofferC KristofferC added the status:merge me PR is reviewed. Merge when all tests are passing label May 8, 2024
@KristofferC KristofferC merged commit 62b5159 into master May 10, 2024
8 checks passed
@KristofferC KristofferC deleted the gb/vecalign branch May 10, 2024 09:29
@KristofferC KristofferC added the backport 1.11 Change should be backported to release-1.11 label May 10, 2024
@inkydragon inkydragon removed the status:merge me PR is reviewed. Merge when all tests are passing label May 17, 2024
KristofferC pushed a commit that referenced this pull request May 20, 2024
@gbaraldi
Make Memory{T} respect the max alignment of the heap (#53748)
94c35f8 
Fixes #53683

(cherry picked from commit 62b5159)
KristofferC pushed a commit that referenced this pull request May 23, 2024
@gbaraldi
Make Memory{T} respect the max alignment of the heap (#53748)
0f010f0 
Fixes #53683

(cherry picked from commit 62b5159)
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label May 28, 2024
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Jul 12, 2024
@gbaraldi @lazarusA
Make Memory{T} respect the max alignment of the heap (JuliaLang#53748)
7b720c0 
Fixes JuliaLang#53683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vecelement test fails on Zen4
5 participants
@gbaraldi @KristofferC @vchuravy @vtjnash @inkydragon