Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wformat-security to build #53546

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Mar 1, 2024

This enhances some printing security:

At present, this warns about calls to printf and scanf functions where
the format string is not a string literal and there are no format arguments,
as in printf (foo);. This may be a security hole if the format string came
from untrusted input and contains ‘%n’. (This is currently a subset of what
-Wformat-nonliteral warns about, but in future warnings may be added to
-Wformat-security that are not included in -Wformat-nonliteral.)

This enhances some printing security:

> At present, this warns about calls to printf and scanf functions where
> the format string is not a string literal and there are no format arguments,
> as in printf (foo);. This may be a security hole if the format string came
> from untrusted input and contains ‘%n’. (This is currently a subset of what
> -Wformat-nonliteral warns about, but in future warnings may be added to
> -Wformat-security that are not included in -Wformat-nonliteral.)
@sjkelly sjkelly added the domain:building Build system, or building Julia or its dependencies label Mar 1, 2024
Copy link
Contributor

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fingolfin fingolfin added the status:merge me PR is reviewed. Merge when all tests are passing label Jul 24, 2024
@giordano giordano merged commit 4ab567f into JuliaLang:master Jul 25, 2024
8 checks passed
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants