Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count GC's time waiting for a safepoint as GC time #53441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Count GC's time waiting for a safepoint as GC time #53441

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b663b0
Count GC's time waiting for a safepoint as GC time
mbauman Feb 22, 2024
c481fe7
track and report waiting time separately
mbauman Feb 22, 2024
1af819d
use the threshold I intended here
mbauman Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use the threshold I intended here
  • Loading branch information
@mbauman
mbauman committed Feb 23, 2024
commit 1af819d5a991340d843e4fca6a0536627718ac8a
2 changes: 1 addition & 1 deletion base/timing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ function time_print(io::IO, elapsedtime, bytes=0, gctime=0, allocs=0, lock_confl
print(io, ", ")
end
print(io, Ryu.writefixed(Float64(100*total_gc_time/elapsedtime), 2), "% gc time")
if gcwaittime/total_gc_time > 0.5
if gcwaittime/total_gc_time > 0.005
print(io, ": ", Ryu.writefixed(Float64(100*gcwaittime/total_gc_time), 0), "% of which was waiting for safepoints")
end
end
Expand Down