Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark codeinstance.specsigflags as atomic #53275

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

vchuravy
Copy link
Member

A correctness fix from #53255

This shouldn't matter much as that field is
only accessed from the runtime, but this
synchronizes the C-header definition, with
the Julia native definition.

Base automatically changed from vc/tagged_ci to master February 10, 2024 22:35
@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Feb 10, 2024
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Feb 11, 2024
@inkydragon
Copy link
Sponsor Member

CI error related: :linux: test x86_64-linux-gnu

core                                             (11) |         failed at 2024-02-11T02:31:01.327
Test Failed at /cache/build/tester-amdci5-9/julialang/julia-master/julia-810f560bdf/share/julia/test/core.jl:46
  Expression: Set((fieldname(T, i) for i = 1:fieldcount(T) if Base.isfieldatomic(T, i))) == Set(c)
   Evaluated: Set([:purity_bits, :max_world, :specptr, :next, :inferred, :isspecsig, :min_world, :precompile, :invoke]) == Set([:purity_bits, :max_world, :specptr, :next, :inferred, :precompile, :min_world, :specsigflags, :invoke])

@vchuravy vchuravy merged commit 37ed82b into master Feb 11, 2024
4 of 7 checks passed
@vchuravy vchuravy deleted the vc/mark_specsigflags_atomic branch February 11, 2024 14:08
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants