less jl_get_global reflection #53250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor code codeup, since this is not supported or working.
Except for those used by staticdata, which uses reflection for everything, this removes most of the remaining runtime callbacks, although a couple also exist to `jl_get_module_binding` still as well.
|
This pr removes some export functions from julia.h, maybe it's worth adding a NEWS? |
|
We don't have a stable API promise for C code, including exports, so I don't think there is anything NEWS-worthy here; we change exports on every release and that is just what should be expected. |
|
Isn't the yeild thing important if someone is embedding julia? |
|
They probably shouldn't call |
|
Makes sense, that question aside LGTM |
vtjnash
added
the
status:merge me
oscardssmith
removed
the
status:merge me
fingolfin
added a commit
to fingolfin/julia
that referenced
this pull request
May 24, 2024
It was removed in PR JuliaLang#53250 but this bit stayed by accident.
fingolfin
added a commit
that referenced
this pull request
May 28, 2024
It was removed in PR #53250 but this bit stayed by accident.
DilumAluthge
pushed a commit
that referenced
this pull request
Jun 3, 2024
It was removed in PR #53250 but this bit stayed by accident.
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
It was removed in PR JuliaLang#53250 but this bit stayed by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining ones I see are
Base.stdoutBase.DL_LOAD_PATHCore._parseBase._atexitBase._postoutputCore.ARGSBase._startBase.Libc.Libdl.dlopenBase.task_done_hookBase.waitBase.CoreLogging.logmsg_shim__init__Base.register_root_moduleBase.loaded_modules_arrayBase.__toplevel__Base.require(of these, the
Base.register_root_module/Base.loaded_modules_arrayshould probably be moved to C still, since it is a thread-safety issue / data-race / deadlock risk right now)