Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict vector indexing of views to 1-based ranges #53249

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Restrict vector indexing of views to 1-based ranges #53249

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
409e6ab
Restrict vector indexing of views to 1-based ranges
jishnub Feb 8, 2024
188c7fc
Remove test that might fail if OffsetArrays is loaded
jishnub Feb 8, 2024
0d891dd
Test for indexing with a offset range
jishnub Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test that might fail if OffsetArrays is loaded
  • Loading branch information
@jishnub
jishnub committed Feb 8, 2024
commit 188c7fc0cc0b039baced74c291ed05fee04b29ec
4 changes: 0 additions & 4 deletions test/subarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,6 @@ end
inds2 = 3:2:5
d1 = @view a1[inds2]
@test d1[axes(d1,1)] == d1[:] == a1[inds2]

if a1 isa SubArray
@test_throws MethodError a1[Base.IdentityUnitRange(2:3)]
end
end
end

Expand Down
Loading