Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpreter_exec.jl test #53218

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Fix interpreter_exec.jl test #53218

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4ced3e
Fix interpreter_exec.jl test
Keno Feb 1, 2024
b8c24bb
handle unassigned `PhiNode` values in `find_ssavalue_uses`
aviatesk Feb 8, 2024
16703da
Apply suggestions from code review
vtjnash Feb 8, 2024
ab74bc2
Update base/compiler/abstractinterpretation.jl
vtjnash Feb 8, 2024
d056498
refactors `interpreter_exec.jl` further (#53246)
aviatesk Feb 9, 2024
750948b
better argument order
aviatesk Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
better argument order
  • Loading branch information
@aviatesk
aviatesk committed Feb 9, 2024
commit 750948b511fbfde121d53d3a6fc55d32071e0b50
10 changes: 5 additions & 5 deletions base/compiler/utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,15 +415,15 @@ function find_ssavalue_uses(body::Vector{Any}, nvals::Int)
if isa(e, SSAValue)
push!(uses[e.id], line)
elseif isa(e, Expr)
find_ssavalue_uses!(e, uses, line)
find_ssavalue_uses!(uses, e, line)
elseif isa(e, PhiNode)
find_ssavalue_uses!(e, uses, line)
find_ssavalue_uses!(uses, e, line)
end
end
return uses
end

function find_ssavalue_uses!(e::Expr, uses::Vector{BitSet}, line::Int)
function find_ssavalue_uses!(uses::Vector{BitSet}, e::Expr, line::Int)
head = e.head
is_meta_expr_head(head) && return
skiparg = (head === :(=))
Expand All @@ -433,12 +433,12 @@ function find_ssavalue_uses!(e::Expr, uses::Vector{BitSet}, line::Int)
elseif isa(a, SSAValue)
push!(uses[a.id], line)
elseif isa(a, Expr)
find_ssavalue_uses!(a, uses, line)
find_ssavalue_uses!(uses, a, line)
end
end
end

function find_ssavalue_uses!(e::PhiNode, uses::Vector{BitSet}, line::Int)
function find_ssavalue_uses!(uses::Vector{BitSet}, e::PhiNode, line::Int)
values = e.values
for i = 1:length(values)
isassigned(values, i) || continue
Expand Down