Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps/libsuitesparse: fix source build #53150

Merged
merged 6 commits into from
Feb 2, 2024
Merged

deps/libsuitesparse: fix source build #53150

merged 6 commits into from
Feb 2, 2024

Conversation

inkydragon
Copy link
Sponsor Member

@inkydragon inkydragon commented Feb 1, 2024 •
edited
Loading

fix #53122

Compiling from source code for testing requires:
Make.user

USE_BINARYBUILDER_LIBSUITESPARSE:=0

@inkydragon inkydragon added domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Feb 1, 2024
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 1, 2024
@vtjnash vtjnash mentioned this pull request Feb 1, 2024
Closed
@vtjnash vtjnash added backport 1.10 Change should be backported to the 1.10 release and removed backport 1.10 Change should be backported to the 1.10 release labels Feb 1, 2024
@inkydragon
Copy link
Sponsor Member Author

Makefile ref: https://github.com/JuliaPackaging/Yggdrasil/blob/608118494321e2c4dfa7a36e7dcc39b6df262dce/S/SuiteSparse/SuiteSparse@7/build_tarballs.jl

@vtjnash vtjnash merged commit 058b511 into JuliaLang:master Feb 2, 2024
3 of 7 checks passed
@inkydragon inkydragon deleted the build-SuiteSparse branch February 2, 2024 13:47
@inkydragon inkydragon removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah approved these changes

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SuiteSparse-7.5.1 build is broken (on source build CI)
3 participants
@inkydragon @ViralBShah @vtjnash