Effects-tune PersitentDict #52954
Merged
Effects-tune PersitentDict #52954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this has a legitimate test failure: |
|
Yeah, that's an embarrassing copy-paste-typo in the |
To in particular allow elimination of dead PersistentDict constructions.
aviatesk
reviewed
Jan 21, 2024
| trie = dict.trie | ||
| h = HAMT.HashState(key) | ||
| found, present, trie, i, bi, top, hs = HAMT.path(trie, key, h, #=persistent=# true) | ||
| HAMT.insert!(found, present, trie, i, bi, hs, val) | ||
| return new{K, V}(top) | ||
| end | ||
| @noinline function KeyValue.set(dict::PersistentDict{K, V}, key) where {K, V} | ||
| @noinline @Base.assume_effects :nothrow :effect_free function KeyValue.set(dict::PersistentDict{K, V}, key::K, val::V) where {K, V} |
There was a problem hiding this comment.
Upon further investigation, it appears that modifying this single line is enough to remove the call to the dead PersistentDict constructor. But, this seems to stem from an inference bug, where we're deleting statements without actually proving terminates.
julia> @noinline Base.@assume_effects :effect_free :nothrow function foo(n)
s = 0
while true
if n - rand(1:10) > 0
s += 1
else
break
end
end
return s
end^C
julia> code_typed((Int,)) do n
foo(n)
nothing
end
1-element Vector{Any}:
CodeInfo(
1 ─ return Main.nothing
) => NothingSo, I'd like to address this bug first and then revisit this PR.
This was referenced Jan 21, 2024
topolarity
pushed a commit
that referenced
this pull request
Jan 31, 2024
To in particular allow elimination of dead PersistentDict constructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To in particular allow elimination of dead PersistentDict constructions.