Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveUtils: avoid side-effect compilation in first @time_imports print #52832

Merged

Conversation

IanButterworth
Copy link
Sponsor Member

Before, the first dep with an __init__() always showed compilation from just compiling the time_imports tooling

% ./julia --startup-file=no -q
julia> @time_imports using NetworkOptions
               ┌ 0.0 ms NetworkOptions.__init__() 
     15.6 ms  NetworkOptions 75.43% compilation time

This PR

% ./julia --startup-file=no -q                                                                
julia> @time_imports using NetworkOptions
               ┌ 0.0 ms NetworkOptions.__init__() 
      4.6 ms  NetworkOptions

Baking @time_imports into the REPL pkgimage didn't help because something in the package load system was invalidating the multi-arg print methods this avoids (couldn't figure that out).

@IanButterworth IanButterworth merged commit dceeafe into JuliaLang:master Jan 10, 2024
5 of 7 checks passed
@IanButterworth IanButterworth deleted the ib/time_imports_comp branch January 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant