Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen eltype in complex hermitian tridiagonal eigen #52802

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Widen eltype in complex hermitian tridiagonal eigen #52802

merged 3 commits into from
Jan 9, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jan 8, 2024

Close #52801 by widening the eltype appropriately.

@jishnub jishnub added the domain:linear algebra Linear algebra label Jan 8, 2024
dkarrasch
dkarrasch approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching it so quickly.

@dkarrasch dkarrasch added the status:merge me PR is reviewed. Merge when all tests are passing label Jan 8, 2024
@jishnub jishnub mentioned this pull request Jan 8, 2024
Closed
MasonProtter
MasonProtter reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MasonProtter MasonProtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eigvals also needs a fix since abs(::Complex{Int}) will give a Float64.

@jishnub jishnub merged commit 17280b2 into master Jan 9, 2024
4 of 7 checks passed
@jishnub jishnub deleted the jishnub/eigencomplexinthermtri branch January 9, 2024 04:11
@IanButterworth IanButterworth removed the status:merge me PR is reviewed. Merge when all tests are passing label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

@MasonProtter MasonProtter MasonProtter left review comments

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in tridiagonal hermitian eigen for Complex{Int} elements
4 participants
@jishnub @dkarrasch @MasonProtter @IanButterworth