inference: thread lattice through memoryop type check #52773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added a commit
that referenced
this pull request
Jan 6, 2024
aviatesk
added a commit
that referenced
this pull request
Jan 6, 2024
We would probably need to backport similar changes to 1.10 too. xref: aviatesk/JET.jl#589
aviatesk
force-pushed
the
avi/memoryop-lattice
branch
from
5707c9a
to
5354a8b
Compare
Keno
reviewed
Jan 6, 2024
| # Check that we can determine the element type | ||
| isa(memtype, DataType) || return false | ||
| elemtype_expected = memoryref_elemtype(memtype) | ||
| elemtype_expected === Union{} && return false | ||
| # Check that the element type is compatible with the element we're assigning | ||
| ⊑ = Core.Compiler.:⊑(𝕃) |
There was a problem hiding this comment.
Aren't we already in Core.Compiler here?
There was a problem hiding this comment.
This is a hack to use the same symbol as a binary operator in the local context.
There was a problem hiding this comment.
A little ugly, but I guess I don't care.
There was a problem hiding this comment.
Should be just Compiler.⊑ then, since Core.Compiler might be a different module from this
There was a problem hiding this comment.
tfuncs.jl is loaded only within Core.Compiler, but let's make this clean in another PR.
There was a problem hiding this comment.
I often load other Compilers that aren't the one in Core
Keno
approved these changes
Jan 6, 2024
aviatesk
added a commit
that referenced
this pull request
Jan 7, 2024
aviatesk
added a commit
that referenced
this pull request
Jan 7, 2024
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would probably need to backport similar changes to 1.10 too.
xref: aviatesk/JET.jl#589