Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompile reason print when nothing #52701

Merged

Conversation

IanButterworth
Copy link
Sponsor Member

Fixup on #52619

Fixes manual compilecache calls and expands tests to cover this logging path which is only a debug on non-interactive

Base.compilecache(Base.identify_package("OrdinaryDiffEq"))
┌ Error: Exception while generating log record in module Base at loading.jl:2598
│   exception =
│    MethodError: no method matching list_reasons(::Nothing)
│
│    Closest candidates are:
│      list_reasons(::Dict{String, Int64})
│       @ Base loading.jl:3319
│
│    Stacktrace:
│      [1] macro expansion
│        @ Base ./logging.jl:376 [inlined]
│      [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool; reasons::Nothing)
...

@IanButterworth
Copy link
Sponsor Member Author

Windows failure is #52679

@IanButterworth IanButterworth merged commit 2d0aeca into JuliaLang:master Jan 2, 2024
5 of 7 checks passed
@IanButterworth IanButterworth deleted the ib/precompile_reasons_fix branch January 2, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants