effects: support callsite @assume_effects annotation
#52400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your job failed. |
aviatesk
force-pushed
the
avi/callsite-assume_effects
branch
from
26da2e3
to
19f95a1
Compare
aviatesk
force-pushed
the
avi/assume_effects-refactoring
branch
from
cc0638b
to
f73df4f
Compare
aviatesk
force-pushed
the
avi/callsite-assume_effects
branch
from
19f95a1
to
19982e7
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/callsite-assume_effects
branch
2 times, most recently
from
9f4579e
to
25eb8fd
Compare
`@assume_effects` on method definitions is very useful, but at some times, its application can be too broad on generic signatures. We've addressed this by defining methods specialized for particular types and applying `@assume_effects` to them. However, this method has downsides, such as being restricted to pre-set types or increasing nearly identical method definitions. To remedy this, this commit introduces a support for callsite `@assume_effects` annotation, enabling finer control over its application. Now the annotations for `@ccall` are just specific instances of callsite `@assume_effects` annotation, so it might be a good idea to replace `@ccall` annotations with callsite `@assume_effects` annotations.
aviatesk
force-pushed
the
avi/callsite-assume_effects
branch
from
25eb8fd
to
e93297a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@assume_effectson method definitions is very useful, but at some times, its application can be too broad on generic signatures. We've addressed this by defining methods specialized for particular types and applying@assume_effectsto them. However, this method has downsides, such as being restricted to pre-set types or increasing nearly identical method definitions.To remedy this, this commit introduces a support for callsite
@assume_effectsannotation, enabling finer control over its application. Now the annotations for@ccallare just specific instances of callsite@assume_effectsannotation, so it might be a good idea to replace@ccallannotations with callsite@assume_effectsannotations.@nanosoldier
runbenchmarks("inference", vs=":master")