reflection: refactor @assume_effects implementation
#52399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/assume_effects-refactoring
branch
from
e1410dd
to
cc0638b
Compare
I am working on implementing a support for callsite `@assume_effects`
annotation, and this update is part of the preparation for that goal.
Along this, I've modified the API from `pushmeta!(::Expr, ::Symbol, args...)`
to `pushmeta!(::Expr, ::Union{Symbol,Expr})`. This change isn't breaking
as long as the `args` are empty, which is the case for most use cases
(actually there is only one usage of `pushmeta!` with non-empty `args`
within Julia base). I've verified on JuliaHub, and there don't appear to
be any packages using `pushmeta!` with non-empty `args`, so there
shouldn't be any (big) issues.
aviatesk
force-pushed
the
avi/assume_effects-refactoring
branch
from
cc0638b
to
f73df4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on implementing a support for callsite
@assume_effectsannotation, and this update is part of the preparation for that goal. Along this, I've modified the API frompushmeta!(::Expr, ::Symbol, args...)topushmeta!(::Expr, ::Union{Symbol,Expr}). This change isn't breaking as long as theargsare empty, which is the case for most use cases (actually there is only one usage ofpushmeta!with non-emptyargswithin Julia base). I've verified on JuliaHub, and there don't appear to be any packages usingpushmeta!with non-emptyargs, so there shouldn't be any (big) issues.