clarify permutedims docs #52261
Merged
clarify permutedims docs #52261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
domain:docs
haakon-e
reviewed
Nov 21, 2023
Co-authored-by: Haakon Ludvig Langeland Ervik <[email protected]>
Co-authored-by: Haakon Ludvig Langeland Ervik <[email protected]>
jishnub
reviewed
Nov 22, 2023
|
Pursuant to the discussion above, I merged the docstrings for |
|
Bump. |
jishnub
reviewed
Dec 14, 2023
Co-authored-by: Jishnu Bhattacharya <[email protected]>
stevengj
commented
Dec 15, 2023
|
Looks good to me, and it's a clear improvement |
jishnub
added
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on discourse, it would be nice if the
permutedimsexamples began with something like an array of strings wheretransposeis inapplicable.This PR simply clarifies the docs and adds a few more examples.