Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up the test case to pass custom codegen params to code_llvm #52144

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix up the test case to pass custom codegen params to code_llvm #52144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/compiler/AbstractInterpreter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ let # generate cache
lookup)
io = IOBuffer()
code_llvm(io, custom_lookup_target, (Bool,Int,); params)
@test occursin("j_sin_", String(take!(io)))
@test !occursin("j_cos_", String(take!(io)))
s = String(take!(io))
@test occursin("j_sin_", s)
@test !occursin("j_cos_", s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this test just not checking anything?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dangers of "negative" tests.

end