cfg_simplify: Avoid ambiguous magic number #52111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was using the sentinel value -1 as a special marker in addition to the negative BB indices. That ambiguity was causing `cfg_simplify!` to fail on functions that merge any BB into the first basic block. This change is to use `typemin(Int)` as a marker instead. Fixes JuliaLang#52058
topolarity
force-pushed
the
fix-52058
branch
from
48a277c
to
7db9c83
Compare
vtjnash
added
compiler:optimizer
|
Before merging this, can you make it so this is a named constant that explains somewhat what it does? |
|
IMO this is fine as is, since the uses of |
|
The test failure in |
|
This does not need to be backported as |
aviatesk
removed
the
backport 1.10
giordano
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was using the sentinel value -1 as a special marker in addition to the negative BB indices. That ambiguity was causing
cfg_simplify!to fail on functions that merge any BB into the first basic block.This change is to use
typemin(Int)as a marker instead.Fixes #52058