Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GC.gc docstring #52008

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Fix GC.gc docstring #52008

merged 3 commits into from
Nov 4, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Nov 3, 2023

GC.gc(true) will perform a full mark (note the use of recollect in gc.c if the previous sweep was not full).

Fixes #51796.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 3, 2023
KristofferC
KristofferC reviewed Nov 3, 2023
View reviewed changes
base/gcutils.jl Outdated Show resolved Hide resolved
NHDaly
NHDaly approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@d-netto d-netto merged commit 7df8781 into master Nov 4, 2023
4 of 7 checks passed
@d-netto d-netto deleted the dcn-fix-gc-docstring branch November 4, 2023 01:54
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@kpamnany kpamnany kpamnany left review comments

@NHDaly NHDaly NHDaly approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

@gbaraldi gbaraldi Awaiting requested review from gbaraldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly confusing documentation for GC.gc()
6 participants
@d-netto @KristofferC @NHDaly @kpamnany @vtjnash @giordano