REPL: Try to fix intermittent hang during precompile #51891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was intermittently observing the REPL precompile process not finishing.
What I believe was happening is the following:
1. The last line of the precompile script is `cd("complete_path\t\t$CTRL_C`
2. As soon as child julia sees the `CTRL_C`, the prompt is terminated,
and a new prompt is echod.
3. The parent julia tries to complete the line by sending `\n`, and
immediately returns, because the child has already written a new
prompt.
4. The child reads the `\n` and enters raw mode (ignoring things like
^D).
5. The parent tries to write `^D` to complete the process, but because
the child is still processing the `\n`, this `^D` is ignored and
the process hangs.
Try to fix this by not writing the superfluous `\n` if the precompile line
ends in `^C`.
brenhinkeller
added
stdlib:REPL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was intermittently observing the REPL precompile process not finishing. What I believe was happening is the following:
cd("complete_path\t\t$CTRL_CCTRL_C, the prompt is terminated, and a new prompt is echod.\n, and immediately returns, because the child has already written a new prompt.\nand enters raw mode (ignoring things like ^D).^Dto complete the process, but because the child is still processing the\n, this^Dis ignored and the process hangs.Try to fix this by not writing the superfluous
\nif the precompile line ends in^C.