Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert the GC preserve into the expanded docs #51884

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Insert the GC preserve into the expanded docs #51884

merged 1 commit into from
Oct 27, 2023

Conversation

vchuravy
Copy link
Sponsor Member

The expanded form is not fully correct since it misses the preservation of
the return value from cconvert. The text below talks about the fact that
cconvert should do the allocations necessary, but the expanded code is
incorrect for any cconvert that actually does this.

@brenhinkeller brenhinkeller added GC Garbage collector domain:docs This change adds or pertains to documentation labels Oct 26, 2023
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Oct 26, 2023
@vchuravy vchuravy merged commit 8382d51 into master Oct 27, 2023
8 of 10 checks passed
@vchuravy vchuravy deleted the vc/docs_cconvert branch October 27, 2023 15:55
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Oct 30, 2023
@kpamnany kpamnany mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vchuravy @vtjnash @giordano @brenhinkeller