Comment out DebugObjectManagerPlugin #51859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prem said this might fix #51794.
|
Can we do so only when on ASAN? |
|
Do we know that this is ASAN specific? I think JITLINK is just not enabled currently on ELF unless we're using the sanitizers. |
|
It's enabled on aarch64 linux |
|
The message is ASAN specific and harmless. The goal is to get JITLink fully functional on all platforms and this plugin is needed for the GDB support. So commenting that out breaks more than it fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prem said this might fix #51794.