Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove-addrspaces pass in the presence of globals with addrspaces #51782

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix remove-addrspaces pass in the presence of globals with addrspaces #51782

merged 1 commit into from
Oct 20, 2023

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Oct 19, 2023 •
edited
Loading

This fixes an assertion that might trigger if we run this pass on sysimg modules. Which we might need to do in aarch64 and other backends that turn on globalIsel

@gbaraldi gbaraldi requested a review from maleadt October 19, 2023 19:29
@maleadt maleadt added the compiler:codegen Generation of LLVM IR and native code label Oct 20, 2023
@maleadt maleadt merged commit 01f6c4c into master Oct 20, 2023
8 checks passed
@maleadt maleadt deleted the gb/remove-addrspace branch October 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbaraldi @vtjnash @maleadt