Move heap_size batching code into pair of functions #51611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I almost want to have one for realloc that takes in old size and new size. But thanks this code needed some DRY |
|
SGTM. I can still reproduce #51601 on this PR, which suggests that the accounting bug fixed in the implementation of the |
|
I implemented the finalizer stuff and on the faulty benchmark it seems to work as expected |
d-netto
reviewed
Oct 26, 2023
|
Bump. |
|
@d-netto are you ok with merging this? |
d-netto
pushed a commit
that referenced
this pull request
Mar 15, 2024
Co-authored-by: Gabriel Baraldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug in
callocaccounting.