Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to names docstring about not implying isdefined #51593

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Add note to names docstring about not implying isdefined #51593

merged 1 commit into from
Jan 20, 2024

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Oct 4, 2023

ref #51584

@brenhinkeller brenhinkeller added the domain:docs This change adds or pertains to documentation label Oct 5, 2023
@Pangoraw
Copy link
Contributor

Pangoraw commented Oct 6, 2023

names(SomeModule) returns public symbols and not exported ones since #50105, so the wording should probably be updated to use "public" instead of "exported" here.

@nsajko
Copy link
Contributor Author

nsajko commented Dec 23, 2023

bump

@nsajko
Copy link
Contributor Author

nsajko commented Jan 5, 2024

@LilithHafner I see you touch this doc string in a recent PR, maybe review?

LilithHafner
LilithHafner reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! A good note to have.

LilithHafner
LilithHafner reviewed Jan 5, 2024
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
@nsajko
Copy link
Contributor Author

nsajko commented Jan 19, 2024

bump

@LilithHafner LilithHafner changed the title docs: add note about not implying being defined to names Add note to names docstring about not implying isdefined Jan 20, 2024
@LilithHafner LilithHafner merged commit 8bb0109 into JuliaLang:master Jan 20, 2024
6 of 8 checks passed
@LilithHafner LilithHafner mentioned this pull request Jan 20, 2024
Closed
@nsajko nsajko deleted the names branch January 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilithHafner LilithHafner LilithHafner left review comments

@Pangoraw Pangoraw Pangoraw approved these changes

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nsajko @Pangoraw @LilithHafner @brenhinkeller