fix some test noise that has been accumulating #51508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Sep 29, 2023
|
Could #51399 (comment) be fixed/silenced here too? |
LilithHafner
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Actually, I just realized that the test that this adds print statement to failed in CI and I don't see the print statement triggering though I think it should.
And this removes some exports from HAMT which I approve of, but should be mentioned in the PR title/commit message or broken out into a different PR.
It seems to be a bug that was introduced, so I can't silence that in an NFC here
They weren't there to begin with, so there is nothing to mention. They just caused noise in the testing, which correctly reports they don't exist. |
vtjnash
added
the
status:merge me
IanButterworth
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NFC]