Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random: allow negative seeds #51416

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Random: allow negative seeds #51416

merged 2 commits into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. Random: allow negative seeds 

    Alternative to #46190, see that PR for background.
There isn't a strong use-case for accepting negative seeds, but probably many people
tried something like `seed = rand(Int); seed!(rng, seed)` and saw it failing.
As it's easy to support, let's do it.

This might "break" some random streams, those for which the upper bit of
`make_seed(seed)[end]` was set, so it's rare.
    @rfourquet
    rfourquet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8c3ba6f View commit details
    Browse the repository at this point in the history

  2. use ~ instead of - plus unsigned to obtain positive numbers

    @rfourquet
    rfourquet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a23c07d View commit details
    Browse the repository at this point in the history