Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra zero byte store in jl_readuntil #51401

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove extra zero byte store in jl_readuntil
Since 3b1bbe3 we no longer do this
for arrays, only strings.
  • Loading branch information
JeffBezanson committed Sep 19, 2023
commit f0c6dc5d9d49c126b43784b7d8a73bd61d786593
1 change: 0 additions & 1 deletion src/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ JL_DLLEXPORT jl_value_t *jl_readuntil(ios_t *s, uint8_t delim, uint8_t str, uint
else {
a->length = n;
a->nrows = n;
((char*)a->data)[n] = '\0';
}
if (str) {
JL_GC_PUSH1(&a);
Expand Down