Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getfield codegen for tuple inputs and unknown symbol fields. #51234

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix getfield codegen for tuple inputs and unknown symbol fields. #51234

merged 1 commit into from
Sep 7, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 7, 2023

Fixes #51233

@maleadt maleadt added compiler:codegen Generation of LLVM IR and native code kind:bugfix This change fixes an existing bug labels Sep 7, 2023
@gbaraldi
Copy link
Member

gbaraldi commented Sep 7, 2023 •
edited
Loading

Oops, LGTM. There's even an assert there for this.

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Sep 7, 2023
@gbaraldi gbaraldi merged commit eab8d6b into master Sep 7, 2023
9 checks passed
@gbaraldi gbaraldi deleted the tb/getfield_tuple branch September 7, 2023 19:36
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Sep 8, 2023
@vtjnash vtjnash mentioned this pull request Nov 28, 2023
Closed
@gbaraldi gbaraldi added the backport 1.10 Change should be backported to the 1.10 release label Nov 28, 2023
KristofferC pushed a commit that referenced this pull request Nov 28, 2023
@maleadt @KristofferC
Fix getfield codegen for tuple inputs and unknown symbol fields. (#51234
0e96c9c 
)

(cherry picked from commit eab8d6b)
@KristofferC KristofferC mentioned this pull request Dec 12, 2023
Merged
17 tasks
KristofferC added a commit that referenced this pull request Dec 17, 2023
@KristofferC
Backports release 1.10 (#52503)
e27685f 
Backported PRs:
- [x] #51234 <!-- Fix getfield codegen for tuple inputs and unknown
symbol fields. -->
- [x] #52170 <!-- fix invalidations related to `ismutable` -->
- [x] #52342 <!-- Add single-term multiplication for `AbstractQ` on
v1.10 and above -->
- [x] #52333 <!-- bugfix for dot of Hermitian{noncommutative} -->
- [x] #52407 <!-- channels: fix memory ordering violation in iterate -->
- [x] #52405 <!-- Bump LLVM to 15.0.7+10 to fix GC issue -->
- [x] #52441 <!-- Remove `Pkg` dependency from `SuiteSparse_jll` -->
- [x] #52367 <!-- docs: add notes about scratchspaces in depot -->
- [x] #52456 <!-- Make `jl_write_coverage_data` dllexported again -->
- [x] #52294 <!-- GC scheduler refinements -->
- [x] #52359 <!-- make custom log macros work -->
- [x] #52548
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaraldi gbaraldi gbaraldi approved these changes

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getfield codegen for unknown symbol cannot handle tuple inputs
5 participants
@maleadt @gbaraldi @vtjnash @KristofferC @DilumAluthge