Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing methods in ml_matches results #50962

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix missing methods in ml_matches results #50962

merged 1 commit into from
Aug 18, 2023

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Aug 17, 2023

This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries.

Fixes: #50722 (comment)

@vtjnash
fix missing methods in ml_matches results
6360aac 
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.
@JeffBezanson JeffBezanson added domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug labels Aug 17, 2023
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Aug 18, 2023 

Error in testset SparseArrays/higherorderfns:
Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-6360aac254\share\julia\stdlib\v1.11\SparseArrays\test\higherorderfns.jl:99
  Expression: #= C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-6360aac254\share\julia\stdlib\v1.11\SparseArrays\test\higherorderfns.jl:99 =# @allocated(map!(*, X, A, B, C)) < 300
   Evaluated: 552 < 300

:/

@vtjnash vtjnash merged commit 762801c into master Aug 18, 2023
6 of 8 checks passed
@vtjnash vtjnash deleted the jn/mlmissingmatches branch August 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @JeffBezanson