Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globalDCE and possibly globalsAA to the pipeline #50908

Merged
merged 4 commits into from
Aug 19, 2023
Merged

Conversation

gbaraldi
Copy link
Member

This removes the unnecessary globals from the module making the IR cleaner and smaller

src/pipeline.cpp Outdated Show resolved Hide resolved
src/pipeline.cpp Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this is supposed to be kept the same as addOptimizationPasses, until we delete that other code?

@gbaraldi
Copy link
Member Author

I think it's already different because the legacy PM is long deprecated on LLVM 15 and is already missing a couple of the passes that we used to run.

@vchuravy
Copy link
Sponsor Member

Yeah, we only have the old code around for GPUCompiler

@gbaraldi
Copy link
Member Author

gbaraldi commented Aug 14, 2023

Hopefully we can move LLVM.jl and GPUCompiler to the newPM in the near future so that we can remove this code.

@brenhinkeller brenhinkeller added the compiler:llvm For issues that relate to LLVM label Aug 15, 2023
@gbaraldi
Copy link
Member Author

Bump!

@maleadt maleadt merged commit 44518a9 into master Aug 19, 2023
6 checks passed
@maleadt maleadt deleted the gb/globals-dce branch August 19, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:llvm For issues that relate to LLVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants