Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 1-arg methods for set comparisons #50862

Merged
merged 6 commits into from
Oct 28, 2023
Merged

add 1-arg methods for set comparisons #50862

merged 6 commits into from
Oct 28, 2023

Conversation

longemen3000
Copy link
Contributor

solves #50733

@brenhinkeller brenhinkeller added the domain:collections Data structures holding multiple items, e.g. sets label Aug 10, 2023
@longemen3000
Copy link
Contributor Author

Test errors are unrelated, only docs are missing and this PR is ready to go

@longemen3000
Copy link
Contributor Author

docs added, with compat for julia 1.11. this is ready for review.

JeffBezanson
JeffBezanson reviewed Aug 14, 2023
View reviewed changes
base/abstractset.jl Outdated Show resolved Hide resolved
@longemen3000
Copy link
Contributor Author

Is it possible to merge this for 1.11?

@oscardssmith oscardssmith added the status:merge me PR is reviewed. Merge when all tests are passing label Oct 24, 2023
@oscardssmith
Copy link
Member

yes

@IanButterworth

This comment has been minimized.

Sign in to view
@IanButterworth IanButterworth merged commit 18f8070 into JuliaLang:master Oct 28, 2023
7 checks passed
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@rfourquet rfourquet rfourquet approved these changes

Assignees
No one assigned
Labels
domain:collections Data structures holding multiple items, e.g. sets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@longemen3000 @oscardssmith @IanButterworth @JeffBezanson @rfourquet @giordano @brenhinkeller