Add Base prefix to list_deletefirst! #50852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when debugging a bizarre issue, probably caused by some earlier undefined behaviour, and I haven't been able to come up with simple reproduction steps. It seems like `current_task().queue` is basically never set after `wait()`. Based on JuliaLang#32903 it seems like raising SIGINT at the right time might trigger this. In any case, if you manage to trigger it, `list_deletefirst!` will fail because it is out of scope. I double-checked this using `@eval Sockets list_deletefirst!`.
|
Probably not that important since this code basically never runs, but is it an issue that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when debugging a bizarre issue, probably caused by some earlier undefined behaviour, and I haven't been able to come up with simple reproduction steps. It seems like
current_task().queueis basically never set afterwait(). Based on #32903 it seems like raising SIGINT at the right time might trigger this.In any case, if you manage to trigger it,
list_deletefirst!will fail because it is out of scope. I double-checked this using@eval Sockets list_deletefirst!with Julia 1.9.2 (and there's only been one change toSocketssince then).