Don't partition alwaysinline functions #50766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alwaysinline functions need to have their bodies in each partition during image compilation in order to be inlined. We were not doing this before, which caused #50749. This fixes that issue by not partitioning alwaysinline functions, and internalizing them into each shard so that they won't cause name conflicts, which should fix #50749.
@timholy / @gbaraldi could you confirm the regression goes away on this PR?