Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ccall tests to node 1 on 32 bit #50350

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

gbaraldi
Copy link
Member

The ccall tests seems to be a very common failure point so move it to node 1 because it usually has less maxrss

@staticfloat
Copy link
Sponsor Member

I'd rather move it unconditionally.

@gbaraldi
Copy link
Member Author

That's fine with me

@vtjnash vtjnash merged commit 92437c2 into JuliaLang:master Jun 30, 2023
6 checks passed
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 5, 2023

Still fails:

Executing tests that run on node 1 only:
--
  | ccall                                             (1) \|        started at 2023-07-05T11:50:01.200
  | fatal: error thrown and no exception handler available.
  | ErrorException("fatal error allocating signal stack: mmap: Cannot allocate memory")
  | ijl_errorf at /cache/build/default-amdci5-2/julialang/julia-master/src/rtutils.c:77
  | alloc_sigstack at /cache/build/default-amdci5-2/julialang/julia-master/src/signals-unix.c:625 [inlined]
  | jl_install_thread_signal_handler at /cache/build/default-amdci5-2/julialang/julia-master/src/signals-unix.c:632
  | jl_init_root_task at /cache/build/default-amdci5-2/julialang/julia-master/src/task.c:1723
  | ijl_adopt_thread at /cache/build/default-amdci5-2/julialang/julia-master/src/threading.c:427
  | unknown function (ip: 0xe62c547b)
  | jl_work_wrapper at /cache/build/default-amdci5-2/julialang/julia-master/src/jl_uv.c:1045
  | uv__queue_work at /workspace/srcdir/libuv/src/threadpool.c:305
  | worker at /workspace/srcdir/libuv/src/threadpool.c:122
  | start_thread at /lib/i386-linux-gnu/libpthread.so.0 (unknown line)
  | clone at /lib/i386-linux-gnu/libc.so.6 (unknown line)
 ```

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 5, 2023

Note that, since 48bc266, only 500 Tasks are permitted before this will crash. We may want a way to bypass that limit for certain use cases (such as this one).

@gbaraldi
Copy link
Member Author

gbaraldi commented Jul 5, 2023

I wonder which test in ccall is stressing this so much, maybe we should skip/reduce the size of it on 32 bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants