fix compatible_vatuple
#50331
Merged
fix compatible_vatuple
#50331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jun 28, 2023
base/compiler/typeutils.jl
Outdated
| (isdefined(vaa, :N) == isdefined(vab, :N)) || return false | ||
| !isdefined(vaa, :N) && return true | ||
| return vaa.N === vab.N | ||
| if isdefined(vaa, :N) |
There was a problem hiding this comment.
Not really a fan of all the nesting levels. if the comparison of the isdefineds is confusing, maybe
if !isdefined(vaa, :N)
return isdefined(vab, :N)
end
isdefined(vab, :N) || return false
return vaa.N == vab.N
?
There was a problem hiding this comment.
I thought about improving the :nothrow-effect analysis in the future by propagating, say, Defined lattice element from isdefined, that has a similar design as Conditional. I believe it's feasible to accomplish it using the pattern you've suggested, so I intend to adopt your style.
|
Would be good to have a test for this - ideally an integration test that reaches it, but if not, I think a unit test is fine. |
Seemingly `vab` has been computed wrongly.
aviatesk
force-pushed
the
avi/compatible_vatuple
branch
from
bff2ee1
to
25e9bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemingly
vabhas been computed wrongly.