fix conversion of empty Dates.CompoundPeriod() to zero units
#50259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompoundPeriod() to zero unitsDates.CompoundPeriod() to zero units
stevengj
approved these changes
Jun 23, 2023
|
I think this can be merged now. |
stevengj
reviewed
Jun 29, 2023
|
I'd argue that this is a bugfix; any chance it can be backported for 1.10.5, @KristofferC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #50193
WRT the fix proposed by @Seelengrab in his comment. Thanks to him for providing the whole fix. This PR fixes the issue and adds a test for the new functionality.