[build] Allow automatically applying Julia's patches to LLVM source #50208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
domain:building
|
Would it be possible to eventually add the same feature for other dependencies that we have custom forks of, such as libuv? |
|
We don't have stable tags for Julia's libuv, which is a major pain point for downstream packagers like spack, so the answer is no. But also, I'm not sure libuv is so commonly forked as llvm is, for which one may want to compile a fork with a new backend enabled not yet available in upstream (which was the main motivation for my PR). |
staticfloat
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when one wants to build Julia with a non-Julia fork of LLVM, but still apply Julia's patches, to be a good citizen. I'm happy to document these new options in the devdocs if #50207 is accepted.