Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print feature flags used for matching pkgimage #50172

Merged
merged 12 commits into from
Aug 7, 2023
Merged

print feature flags used for matching pkgimage #50172

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cf05e2f
print feature flags used for matching pkgimage
vchuravy Jun 15, 2023
6e031a7
Collect cache file rejection messages
pchintalapudi Jun 20, 2023
3798c7b
Apply suggestions from code review
vchuravy Jun 23, 2023
87e2596
pass rejection reason to caller
vchuravy Jun 23, 2023
7165525
fixup! pass rejection reason to caller
vchuravy Jun 23, 2023
00ddf10
Apply suggestions from code review
vchuravy Jul 11, 2023
b920030
add JL_NOTSAFEPOINT
vchuravy Jul 12, 2023
c77be08
fix fallback
vchuravy Jul 12, 2023
22f1077
fixup! fix fallback
vchuravy Jul 12, 2023
713095c
fixup! fixup! fix fallback
vchuravy Jul 20, 2023
4e9811b
fixup! fixup! fixup! fix fallback
vchuravy Jul 20, 2023
bcc50ec
fixup! fixup! fixup! fixup! fix fallback
vchuravy Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix fallback
  • Loading branch information
@vchuravy
vchuravy committed Aug 5, 2023
commit c77be087a19fb4a4221b549bfc0bbe3a87d8d880
4 changes: 2 additions & 2 deletions src/processor_fallback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ static TargetData<1> arg_target_data(const TargetData<1> &arg, bool require_host
return res;
}

static uint32_t sysimg_init_cb(const void *id)
static uint32_t sysimg_init_cb(const void *id, jl_value_t **rejection_reason)
{
// First see what target is requested for the JIT.
auto &cmdline = get_cmdline_targets();
Expand All @@ -51,7 +51,7 @@ static uint32_t sysimg_init_cb(const void *id)
return best_idx;
}

static uint32_t pkgimg_init_cb(const void *id)
static uint32_t pkgimg_init_cb(const void *id, jl_value_t **rejection_reason)
{
TargetData<1> target = jit_targets.front();
// Find the last name match or use the default one.
Expand Down