Highlight extra required methods for iterators #50069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A student on exercism read this section and did not realise that they had to define at least one of
Base.IteratorSize
andlength
.I'm not totally happy with this revision, but it does seem a bit clearer to me. Some particular bits that I think could be better:
eltype
is called a required method, but that's only sorta true because the default definition is probably fine.Because the visual appearance of the docs isn't totally clear from the markdown, here are before and after images.
Before:
After:
Another variant option (one big table for all conditionally-required methods):
Source for the variant option